Skip to content

Traktor Kontrol S4 Mk3: document new effects mapping#774

Merged
Swiftb0y merged 1 commit intomixxxdj:2.6from
ronso0:s4-4effectunits
Jun 4, 2025
Merged

Traktor Kontrol S4 Mk3: document new effects mapping#774
Swiftb0y merged 1 commit intomixxxdj:2.6from
ronso0:s4-4effectunits

Conversation

@ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 4, 2025

@ronso0
Copy link
Member Author

ronso0 commented Jun 4, 2025

No netlify hook?

Comment on lines +328 to +351

This mapping uses the :ref:`Standard Effects Mapping <controller-effects-mapping>` to control 4 effect units.
It has a "focus mode" where one effect is mapped to the knobs and buttons 1/2/3. In that mode, the knobs and buttons
control the first three knob and button parameters of that effect.

Note: in the skin, effect parameters can be swapped with drag'n'drop.

=================== ====================================================================================================================
Control Description
=================== ====================================================================================================================
FX knob 1/2/3 - Normal mode: Meta knob of effect 1/2/3
- Focus mode: parameter knob 1/2/3 of the focused effect
- Focus mode + Shift: same as Normal modes
FX knob 4 - Wet/dry mix (volume) of the effect unit
FX button 1/2/3 - Normal: toggle (short press) or trigger (long press) the effect
- Focus select mode: focus effect 1/2/3, or clear focused effect. The LED is lit for the currently focused effect
- Focus mode: toggle (short press) or trigger (long press) parameter button 1/2/3 of the focused effect
- Focus mode + Shift: same as Normal mode
FX focus button - Long press: start focus select mode
- Short press: clear focused effect (if any) or expand/collapse the effect unit in the skin to show
the effect parameters
- LED blinks if an effect is focused
=================== ====================================================================================================================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, the standard effects mapping can change so does it make sense to duplicate the info here? Shouldn't the link to the central description suffice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I reimplemented the standard mapping from midi-components. So if the standard mapping is changed, that and the S4 mapping would indeed differ, but the documentation here would still be correct.

Besides, the standard mapping documentation is a block of text.
This here is a nice, compact table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. I assumed you just deployed midi-components. Makes total sense to have the redudancy here then.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 4, 2025

I guess merge?

@Swiftb0y Swiftb0y merged commit c9f2468 into mixxxdj:2.6 Jun 4, 2025
4 of 5 checks passed
@ronso0
Copy link
Member Author

ronso0 commented Jun 4, 2025

I guess merge?

naa, mixxxdj/mixxx#14895 hasn't been merged.
Dunno how long that'll take, it's not super big but still..

Can you revert this? Force-push is okay I think

@ronso0
Copy link
Member Author

ronso0 commented Jun 4, 2025

I just reverted this on 2.6, will open a new PR when there's some response on mixxxdj/mixxx#14895

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 5, 2025

whoops. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants