-
Notifications
You must be signed in to change notification settings - Fork 145
Credits drain #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Credits drain #835
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,8 @@ | |
| } | ||
|
|
||
| smv_tag_whitelist = r"^$" | ||
| smv_branch_whitelist = r"^(main|(\d+)\.(\d+))$" | ||
| # smv_branch_whitelist = r"^(main|(\d+)\.(\d+))$" | ||
| smv_branch_whitelist = r"^(?:main|2.5)$" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this change do?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This only build the main and 2.5 branch.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are pages high ranked by search engines - otherwise they wouldn't have so much hits - blocking them would prevent new users from Mixxx. |
||
| smv_remote_whitelist = r"^origin$" | ||
| # Mark all branches in the form "N.M" as released except "2.6" | ||
| smv_released_pattern = r"^.*/(?!2\.6)(\d+)\.(\d+)$" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the current transfer, should we also add
*.pngfrom the_static/folder?Also, I am wondering if we should add a default somewhere between
30or300. Arguably, when we test new deployment, it comes from a new environment, so cache will be cold, and if one wants to check the main website right after a change, they can always SHIFT+F5 to clear the cache.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no experience with this. My original Idea was to fix low hanging fruits.
To "buy" some time for the hoster change.
But if we are able to do the switch within on or two month we can do such things step by step with benchmarking and usability test later.