Skip to content

docs: Add Stem VU Meter controls to appendix#841

Open
xARSENICx wants to merge 2 commits intomixxxdj:mainfrom
xARSENICx:stem-vu-meter-docs
Open

docs: Add Stem VU Meter controls to appendix#841
xARSENICx wants to merge 2 commits intomixxxdj:mainfrom
xARSENICx:stem-vu-meter-docs

Conversation

@xARSENICx
Copy link

@xARSENICx xARSENICx commented Jan 27, 2026

Goes with PR.

This is my first time writing manual doc for a feature, so I apologize for any lack of foresight

@xARSENICx xARSENICx changed the base branch from 2.5 to 2.6 January 27, 2026 20:09
@JoergAtGithub
Copy link
Member

Please target this to main branch, same as the PR with the code

@xARSENICx xARSENICx changed the base branch from 2.6 to main January 27, 2026 20:21
@xARSENICx
Copy link
Author

Please target this to main branch, same as the PR with the code

Ok. Does this look fine to you? (The number of file changes got me worried 😓 )

@JoergAtGithub
Copy link
Member

You only changed the target of the PR on the GitHub website. You need also to rebase your git branch.

Copy link
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the decision was made to document [ChannelN_StemM] COs alongside other channel COs ([ChannelX], [SamplerX] or [PreviewDeckX]). Either those new CO should be brought in the same way, alongside the other existing vu_meter_... sections, or we should bring those existing one the newly introduced section.

Copy link
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

I will merge the PR in the main repo, but I'd like to wait for @Serveny's PR to go in before we merge this one, so this will be a great test for it.

.. mixxx:control:: [ChannelN],VuMeter
[PreviewDeckN],VuMeter
[SamplerN],VuMeter
[ChannelN_StemM],vu_meter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.5 VuMeter has already been replaced by vu_meter (VuMeter moved to deprecated section)
Guess we need to merge 2.5 -> 2.6 -> main.
Will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants