Skip to content

feat: add support for Android #15565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoergAtGithub merged 1 commit into from
Nov 22, 2025
Merged

feat: add support for Android #15565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 89 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ on:
required: false
MACOS_NOTARIZATION_APP_SPECIFIC_PASSWORD:
required: false
ANDROID_SIGNING_KEYSTORE_BASE64:
required: false
ANDROID_SIGNING_PASSWORD:
required: false
NETLIFY_BUILD_HOOK:
required: false
RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY:
Expand Down Expand Up @@ -173,11 +177,36 @@ jobs:
artifacts_slug: windows-winarm
qt_qpa_platform: windows
arch: arm64
- name: Android 15 arm64
os: ubuntu-24.04
# DBUILD_TESTING=OFF: error: OpenMP support and version of OpenMP (31, 40 or 45) differs
cmake_args: >-
-DBULK=ON
-DQT6=ON
-DQML=ON
-DHID=ON
-DVCPKG_TARGET_TRIPLET=arm64-android
-DVCPKG_DEFAULT_HOST_TRIPLET=x64-linux-release
-DCMAKE_SYSTEM_NAME=Android
-DBUILD_TESTING=OFF
-DBUILD_BENCH=OFF
buildenv_basepath: /home/runner/buildenv
buildenv_script: tools/android_buildenv.sh
artifacts_name: Android 15 APK
artifacts_path: build/android-build/build/outputs/apk/release/*.apk
artifacts_slug: android-15
compiler_cache: ccache
compiler_cache_path: /home/runner/.cache/ccache
crosscompile: true
arch: arm64

env:
# macOS codesigning
MACOS_CODESIGN_CERTIFICATE_P12_BASE64: ${{ secrets.MACOS_CODESIGN_CERTIFICATE_P12_BASE64 }}
MACOS_CODESIGN_CERTIFICATE_PASSWORD: ${{ secrets.MACOS_CODESIGN_CERTIFICATE_PASSWORD }}
# Android signing
ANDROID_SIGNING_KEYSTORE_BASE64: ${{ secrets.ANDROID_SIGNING_KEYSTORE_BASE64 }}
ANDROID_SIGNING_PASSWORD: ${{ secrets.ANDROID_SIGNING_PASSWORD }}

runs-on: ${{ matrix.os }}
name: ${{ matrix.name }}
Expand Down Expand Up @@ -279,6 +308,33 @@ jobs:
echo "CMAKE_ARGS_EXTRA=${CMAKE_ARGS_EXTRA} -DAPPLE_CODESIGN_IDENTITY=${APPLE_CODESIGN_IDENTITY}" >> "${GITHUB_ENV}"
echo "APPLE_CODESIGN_IDENTITY=${APPLE_CODESIGN_IDENTITY}" >> $GITHUB_ENV

- name: "[android] Setup signing key"
if: startsWith(matrix.artifacts_slug, 'android')
run: |
if [ -z "${ANDROID_SIGNING_KEYSTORE_BASE64}" ]; then
Copy link
Member

@JoergAtGithub JoergAtGithub Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to register an Android code-sign key in name of Mixxx e.V. ?

Copy link
Member Author

@acolombier acolombier Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, we can simply generate a key with the Mixxx e.V as organisation. I have done that already, I will upload the secret once we merge the PR

Copy link
Member Author

@acolombier acolombier Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have setup a certificate for CN=Android App, OU=Mixxx Development Team, O=Mixxx e.V now

# If no signing key is available (e.g running on a fork), generate a temporary key
keytool \
-genkey \
-keystore mixxx.keystore \
-alias mixxx \
-keyalg RSA \
-keysize 2048 \
-validity 365 \
-keypass mixxxandroid \
-storepass mixxxandroid \
-dname "CN=${{ github.actor }}"
echo "QT_ANDROID_KEYSTORE_ALIAS=mixxx" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_KEY_PASS=mixxxandroid" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_STORE_PASS=mixxxandroid" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_PATH=${{ github.workspace }}/mixxx.keystore" >> $GITHUB_ENV
else
echo "${{ env.ANDROID_SIGNING_KEYSTORE_BASE64 }}" | base64 -d -o ${{ github.workspace }}/mixxx.keystore
echo "QT_ANDROID_KEYSTORE_ALIAS=mixxx" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_KEY_PASS=${{ env.ANDROID_SIGNING_PASSWORD }}" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_STORE_PASS=${{ env.ANDROID_SIGNING_PASSWORD }}" >> $GITHUB_ENV
echo "QT_ANDROID_KEYSTORE_PATH=${{ github.workspace }}/mixxx.keystore" >> $GITHUB_ENV
fi

- name: "[macOS/Linux] Set up build environment"
if: matrix.buildenv_script != null && runner.os != 'Windows'
run: ${{ matrix.buildenv_script }} setup
Expand Down Expand Up @@ -312,6 +368,29 @@ jobs:
${{ matrix.compiler_cache }} --max-size=2G
if: runner.os != 'windows'

# Remove unused pre-installed software as the runner runs out of space otherwise
# Currently freeing up about 17.7G, ~20%
- name: "[android] Free up disk space"
if: startsWith(matrix.artifacts_slug, 'android')
run: |
sudo apt-get autoremove -y && sudo apt-get clean
sudo rm -rf /home/packer # Free up 677M
sudo rm -rf /opt/az # Free up 649M
sudo rm -rf /opt/google # Free up 378M
sudo rm -rf /opt/hostedtoolcache/CodeQL # Free up 1.6G
sudo rm -rf /opt/hostedtoolcache/go # Free up 808M
sudo rm -rf /opt/hostedtoolcache/node # Free up 532M
sudo rm -rf /opt/hostedtoolcache/PyPy # Free up 520M
sudo rm -rf /opt/hostedtoolcache/Python # Free up 1.5G
sudo rm -rf /opt/microsoft # Free up 781M
sudo rm -rf /opt/pipx # Free up 499M
sudo rm -rf /usr/lib/google-cloud-sdk # Free up 957M
sudo rm -rf /usr/local/julia1.11.7 # Free up 996M
sudo rm -rf /usr/local/share/powershell # Free up 1.3G
sudo rm -rf /usr/share/dotnet # Free up 3.4G
sudo rm -rf /usr/share/swift # Free up 3.2G
sudo rm -rf /usr/local/share/vcpkg # Size unknown, but obvious duplicate

- name: "Create build directory"
run: mkdir build

Expand Down Expand Up @@ -424,7 +503,7 @@ jobs:
path: ${{ github.workspace }}/build/_CPack_Packages/win64/WIX/wix.log

- name: "[Ubuntu] Import PPA GPG key"
if: startsWith(matrix.os, 'ubuntu') && env.RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY != null
if: startsWith(matrix.os, 'ubuntu') && matrix.crosscompile != true && env.RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY != null
run: gpg --import <(echo "${{ secrets.RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY }}")
env:
RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY: ${{ secrets.RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY }}
Expand Down Expand Up @@ -496,6 +575,15 @@ jobs:
--dest-url 'https://downloads.mixxx.org'
${{ matrix.artifacts_path }}

# TODO create a F-droid repo?
# - name: fdroid nightly
# run: |
# sudo add-apt-repository ppa:fdroid/fdroidserver
# sudo apt-get update
# sudo apt-get install apksigner fdroidserver --no-install-recommends
# export DEBUG_KEYSTORE=$
# fdroid nightly --archive-older 10

# Warning: do not move this step before restoring caches or it will break caching due to
# https://github.com/actions/cache/issues/531
- name: "[Windows] Install rsync and openssh"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ jobs:
MACOS_CODESIGN_CERTIFICATE_P12_BASE64: ${{ secrets.MACOS_CODESIGN_CERTIFICATE_P12_BASE64 }}
MACOS_CODESIGN_CERTIFICATE_PASSWORD: ${{ secrets.MACOS_CODESIGN_CERTIFICATE_PASSWORD }}
MACOS_NOTARIZATION_APP_SPECIFIC_PASSWORD: ${{ secrets.MACOS_NOTARIZATION_APP_SPECIFIC_PASSWORD }}
ANDROID_SIGNING_KEYSTORE_BASE64: ${{ secrets.ANDROID_SIGNING_KEYSTORE_BASE64 }}
ANDROID_SIGNING_PASSWORD: ${{ secrets.ANDROID_SIGNING_PASSWORD }}
NETLIFY_BUILD_HOOK: ${{ secrets.NETLIFY_BUILD_HOOK }}
RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY: ${{ secrets.RRYAN_AT_MIXXX_DOT_ORG_GPG_PRIVATE_KEY }}

Expand Down
Loading
Loading