forked from microsoft/vcpkg
-
Notifications
You must be signed in to change notification settings - Fork 9
Create GH release with buildenvs #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acolombier
wants to merge
4
commits into
mixxxdj:2.6
Choose a base branch
from
acolombier:feat/create-gh-release-with-buildenvs
base: 2.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Generate hash for artifacts (e.g. dmg, deb files) built by CI to downloads.mixxx.org. | ||
|
|
||
| set -eu -o pipefail | ||
|
|
||
| # realpath does not exist on macOS | ||
| command -v realpath >/dev/null 2>&1 || realpath() { | ||
| [[ "$1" = /* ]] && echo "$1" || echo "${PWD}/${1#./}" | ||
| } | ||
|
|
||
| # sha256sum doesn't exist on Windows (Git Bash) or macOS | ||
| command -v sha256sum >/dev/null 2>&1 || sha256sum() { | ||
| openssl dgst -sha256 "$@" | sed 's/^SHA256(\(.*\))= \(\w\+\)$/\2 \1/' | ||
| } | ||
|
|
||
| for FILEPATH in "$@" | ||
| do | ||
| echo "Generating hash for artifact: ${FILEPATH}" | ||
| FILENAME="$(basename "${FILEPATH}")" | ||
| FILENAME_HASH="${FILENAME}.sha256sum" | ||
| FILEPATH_HASH="${FILEPATH}.sha256sum" | ||
|
|
||
| # There should be no path components in the shasum file, so we need to cd to it first. | ||
| pushd "$(dirname "$(realpath "${FILEPATH}")")" | ||
| sha256sum "${FILENAME}" > "${FILENAME_HASH}" | ||
| popd | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normally have the name on top. You seems to have reverted the sort order of elements.
Please keep the normal sort order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean just "name first" or is there some kind of bespoke ranking I should follow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if there is something like this.
It is just a good practice to follow the examples in the GitHub Docs:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which example you are referring to. Only order I can find is the following:

Let's just agree to disagree here. However, I'm not willing to block this pressing optimisation over such a minor point. Here are the used keys:
runenvifidshellnamePlease give me what order you want and I will update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong demands in detail, but it shall be consistent with our other workflow for a good reading experience.
In https://github.com/mixxxdj/mixxx/blob/main/.github/workflows/build.yml we have: