Skip to content

Doesn't pickup changes in newly created directories with Linux::Inotify2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cnmota wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Doesn't pickup changes in newly created directories with Linux::Inotify2 #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1e2d6
Update lib/Filesys/Notify/Simple.pm
cnmota Feb 2, 2012
08c095f
Update lib/Filesys/Notify/Simple.pm
cnmota Feb 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion lib/Filesys/Notify/Simple.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,20 @@ sub wait_inotify2 {

my $fs = _full_scan(@path);
for my $path (keys %$fs) {
$inotify->watch($path, &IN_MODIFY|&IN_CREATE|&IN_DELETE|&IN_DELETE_SELF|&IN_MOVE_SELF);
$inotify->watch($path,&IN_MODIFY|&IN_CREATE|&IN_DELETE|&IN_DELETE_SELF|&IN_MOVE_SELF);
}

return sub {
my $cb = shift;
$inotify->blocking(1);
my @events = $inotify->read;

for (@events) {
if (-d $_->fullname && $_->IN_CREATE) {
$inotify->watch($_->fullname,&IN_MODIFY|&IN_CREATE|&IN_DELETE|&IN_DELETE_SELF|&IN_MOVE_SELF);
}
}

$cb->(map { +{ path => $_->fullname } } @events);
};
}
Expand Down Expand Up @@ -149,6 +156,18 @@ sub _compare_fs {
}
}

sub dir_empty {
my ($path) = @;

return 0 unless -d $path;

opendir my($dir), $path;
my @content = grep {$_ !~ /^..?$/} readdir $dir;
closedir($dir);

return scalar(@content) ? 0 : 1;
}

sub _full_scan {
my @paths = @_;
require File::Find;
Expand All @@ -160,6 +179,9 @@ sub _full_scan {
wanted => sub {
my $fullname = $File::Find::fullname || File::Spec->rel2abs($File::Find::name);
$map{Cwd::realpath($File::Find::dir)}{$fullname} = _stat($fullname);
if (_dir_empty($fullname)) {
$map{$fullname}{$fullname} = {};
}
},
follow_fast => 1,
follow_skip => 2,
Expand Down