Fix event emitting from empty directories #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/empty-directory-watch
branch
2 times, most recently
from
cddee23 to
d758d10
Compare
Author
|
Added another test which needs #23 to work correctly on windows. |
mgreter
force-pushed
the
bugfix/empty-directory-watch
branch
from
d758d10 to
8f5a9fc
Compare
There was no event emitted if the last entry from a directory was removed. Keep track of all directories in a specific location (`.`) inside the fs hash.
mgreter
force-pushed
the
bugfix/empty-directory-watch
branch
from
8f5a9fc to
aedb877
Compare
Author
|
OK, was simply a timing issue, wasn't aware of the 2 seconds polling interval ... |
Author
|
Made the interval configurable from outside, hope you don't mind. Feel free to cherry pick the bits you like. I hope it was worth the effort. I will use https://github.com/mgreter/Filesys-Notify-Simple in the meantime for bundling my stuff on windows to get a working file watcher. Thanks! |
And use it to speed up unit tests
mgreter
force-pushed
the
bugfix/empty-directory-watch
branch
from
b3de195 to
9ca917b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no event emitted if the last entry from a
directory was removed. Basically the same fix as in
the linked issue (thx @cnmota). I hope this doesn't
degrade compare performance too much!
Fixes #8