Support psgix.cleanup (and psgix.cleanup.handlers)#132
Open
jrubinator wants to merge 5 commits intomiyagawa:masterfrom
Open
Support psgix.cleanup (and psgix.cleanup.handlers)#132jrubinator wants to merge 5 commits intomiyagawa:masterfrom
jrubinator wants to merge 5 commits intomiyagawa:masterfrom
Conversation
Owner
|
probably a dupe of #53 |
Author
|
Hmm, I think you're right. Wish I'd done a better job searching for that first 😝 I'll see if I can wake up that seven-year-old PR. Assuming I can, I'm happy to close this one. |
Author
|
@miyagawa I think that branch is too old to re-garner momentum. I'm happy to implement turning off keep-alive connections when there are cleanup handlers here, would you be okay with that? |
Implement the proposal at https://github.com/plack/psgi-specs/wiki/Proposal:-PSGI-environment-cleanup-handlers. This seems to work for me, at least the subroutines get run, and you can e.g. "sleep 10" in the cleanup handler without holding up the request. One potential caveat here is that by passing the $env hash to the post_client_connection_hook routine we might be causing something evil, but I haven't spotted any problems with it so far. Note that we have to re-check the harakiri flag in post_client_connection_hook because the cleanup handlers might set it.
(no additional testing, as keepalive behavior isn't currently tested or easily accessible from tests).
Author
|
I refactored to use #53 (since that correctly handled cleanup-harakiri interaction), and added the requested |
Author
|
:( |
|
@miyagawa - any chance this can be merged into a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds psgix.cleanup* handling to Starman.