Make READ_TIMEOUT configurable on the command line#44
Open
yannk wants to merge 1 commit intomiyagawa:masterfrom
Open
Make READ_TIMEOUT configurable on the command line#44yannk wants to merge 1 commit intomiyagawa:masterfrom
yannk wants to merge 1 commit intomiyagawa:masterfrom
Conversation
It allows Starman to sit nicely behind a balancer keeping backend connections
open for a long time (pre-opening or just using keep-alive). Without
this change the behaviour is 5 seconds timeout, and depending on backend
utilization it could be likely that a new request hit the timeout just after
a client connection comes in.
t=0.0s, balancer opens connection, Starman block reading headers.
t~4.9s, client connection hits balancer, balancer assign preopened
backend.
t~5.0s, timeout!
t~5.0s, RST if race. or FIN to balancer with request not processed.
Owner
|
I like to merge this patch but it doesn't seem to apply cleanly against the current master. Can you rebase and do push -f ? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows Starman to sit nicely behind a balancer keeping backend connections
open for a long time (pre-opening or just using keep-alive). Without
this change the behaviour is 5 seconds timeout, and depending on backend
utilization it could be likely that a new request hit the timeout just after
a client connection comes in.
t=0.0s, balancer opens connection, Starman block reading headers.
t
4.9s, client connection hits balancer, balancer assign preopened5.0s, timeout!backend.
t
t~5.0s, RST if race. or FIN to balancer with request not processed.