Skip to content

rmall command integration#352

Open
Gayan-Kaushalya wants to merge 11 commits intomiyurud:masterfrom
Gayan-Kaushalya:master
Open

rmall command integration#352
Gayan-Kaushalya wants to merge 11 commits intomiyurud:masterfrom
Gayan-Kaushalya:master

Conversation

@Gayan-Kaushalya
Copy link
Contributor

@Gayan-Kaushalya Gayan-Kaushalya commented Feb 2, 2026

A new "rmall" command was implemented to remove all the uploaded graphs in JasmineGraph. This command can be used instead of removing graphs one by one.

image

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.94%. Comparing base (c52c17b) to head (ed9fccc).

Files with missing lines Patch % Lines
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 44 Missing ⚠️
src/frontend/ui/JasmineGraphFrontEndUI.cpp 0.00% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #352      +/-   ##
=========================================
- Coverage    0.95%   0.94%   -0.01%     
=========================================
  Files         108     108              
  Lines       26278   26366      +88     
  Branches    17306   17370      +64     
=========================================
  Hits          250     250              
- Misses      25812   25900      +88     
  Partials      216     216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miyurud
Copy link
Owner

miyurud commented Feb 5, 2026

Please add integration tests covering this scenario

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes the query result structure is known. No validation if the result is empty. Consider adding bounds checking.

Copy link
Contributor Author

@Gayan-Kaushalya Gayan-Kaushalya Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sir, is this what you are mentioning about?

Copy link
Owner

@miyurud miyurud Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try the following?

for (const auto& row : graphIdResults) {
    try {
        std::string graphID = row.at(0).second;
        // use graphID
    } catch (const std::out_of_range& e) {
        frontend_logger.error("Invalid row structure: " + e.what() + "\n");
    }
}

@miyurud
Copy link
Owner

miyurud commented Feb 6, 2026

For systems with many graphs, does this perform efficiently? The serial removal might be slow.

@Gayan-Kaushalya Gayan-Kaushalya force-pushed the master branch 2 times, most recently from ed9fccc to 363e408 Compare February 15, 2026 10:03
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments