Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
- Coverage 0.95% 0.94% -0.01%
=========================================
Files 108 108
Lines 26278 26366 +88
Branches 17306 17370 +64
=========================================
Hits 250 250
- Misses 25812 25900 +88
Partials 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miyurud
reviewed
Feb 4, 2026
Owner
|
Please add integration tests covering this scenario |
miyurud
reviewed
Feb 5, 2026
miyurud
reviewed
Feb 6, 2026
miyurud
reviewed
Feb 6, 2026
miyurud
reviewed
Feb 6, 2026
Owner
There was a problem hiding this comment.
This assumes the query result structure is known. No validation if the result is empty. Consider adding bounds checking.
Contributor
Author
Owner
There was a problem hiding this comment.
Can you try the following?
for (const auto& row : graphIdResults) {
try {
std::string graphID = row.at(0).second;
// use graphID
} catch (const std::out_of_range& e) {
frontend_logger.error("Invalid row structure: " + e.what() + "\n");
}
}
miyurud
reviewed
Feb 6, 2026
Owner
|
For systems with many graphs, does this perform efficiently? The serial removal might be slow. |
ed9fccc to
363e408
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




A new "rmall" command was implemented to remove all the uploaded graphs in JasmineGraph. This command can be used instead of removing graphs one by one.