Fix API issues, add JWT support, improve example templates and docs#67
Merged
mkalioby merged 2 commits intomkalioby:v2.0from Mar 28, 2026
Merged
Fix API issues, add JWT support, improve example templates and docs#67mkalioby merged 2 commits intomkalioby:v2.0from
mkalioby merged 2 commits intomkalioby:v2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and improvements for the v2.0 branch:
API fixes
RetrieveDestroyAPIView→RetrieveUpdateDestroyAPIView— OpenAPI schema now correctly shows PATCH method{}with "At least one field must be provided"namefield validation —min_length=1prevents blank passkey namesauth_complete_service— catches all exceptions, not justValueError(prevents 500s from FIDO2 errors)Example project
rest_framework_simplejwtin INSTALLED_APPS withJWTAuthentication/api/auth/token,/api/auth/token/refresh,/api/auth/token/verifyPOST /api/auth/loginreturns same token format as passkey authcontentType(was sending form data).html()→.text()for user-controlled key nameDocs
docs.Example.md→docs/Example.md)exmple/testapp→example/test_app)Tests