Skip to content

Omit all ordinal property keys in pretty plz notation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkantor merged 1 commit into from
Jan 3, 2025
Merged

Omit all ordinal property keys in pretty plz notation #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/language/unparsing/pretty-plz.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,19 +132,25 @@ const sugarFreeMolecule = (value: Molecule) => {
return either.makeRight(openBrace + closeBrace)
} else {
const keyValuePairsAsStrings: string[] = []
let ordinalPropertyKeyCounter = 0n
for (const [propertyKey, propertyValue] of entries) {
const valueAsStringResult = atomOrMolecule(propertyValue)
if (either.isLeft(valueAsStringResult)) {
return valueAsStringResult
}

keyValuePairsAsStrings.push(
// TODO: Intelligently omit all ordinal property keys, not just `0`.
(propertyKey === '0'
? ''
: kleur.cyan(quoteIfNecessary(propertyKey).concat(colon)).concat(' ')
).concat(valueAsStringResult.value),
)
// Omit ordinal property keys:
if (propertyKey === String(ordinalPropertyKeyCounter)) {
keyValuePairsAsStrings.push(valueAsStringResult.value)
ordinalPropertyKeyCounter += 1n
} else {
keyValuePairsAsStrings.push(
kleur
.cyan(quoteIfNecessary(propertyKey).concat(colon))
.concat(' ')
.concat(valueAsStringResult.value),
)
}
}

return either.makeRight(
Expand Down
Loading