Simplify @lookup
#37
Merged
Simplify @lookup
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `@index` exists, expressions like `:a.b` can be modeled as a `@lookup` followed by an `@index`. This helps to simplify `@lookup`'s implementation.
Only accept a single atomic key (not a potentially-molecular query).
mkantor
force-pushed
the
dumb-down-lookup
branch
from
2c74b99 to
ad4dc76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
@indexexists, expressions like:a.bcan be modeled as a@lookupfollowed by an@index, so@lookupitself doesn't need to know how to drill down into objects.This brings with it syntax improvements: dotted paths in lookups are now handled at the parsing layer, which means that quoting/escaping is nicer (e.g.
:"key containing . which is quoted".propertyis valid plz syntax).