Infix notation #60
Merged
Infix notation #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkantor
force-pushed
the
infix-notation
branch
2 times, most recently
from
a016077 to
cb48fe1
Compare
This commit also involves rewriting many parsers and refactoring the end-to-end tests.
After trying out both I think I prefer this and imagine it's what most people will expect. I've preserved my flip-flopping in version control history for posterity.
Allow a newline either before or after the operator, just not both. Previously newlines after operators were forbidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
1 + 1is2(🎉), and pipe/flow operators have been introduced. This is a large changeset as it involves rewriting many of the parsers.