Upgrade actions/checkout and best-of-lists action#352
Upgrade actions/checkout and best-of-lists action#352sebastiaanspeck wants to merge 1 commit intomkdocs:mainfrom
Conversation
|
Is this the result of a Dependabot run? Or did you do it manually? Why did you uncomment the release part? We don't want those. Also, we must keep using our own fork of best-of-generator. |
| - name: install best-of-generator | ||
| run: pip install git+https://github.com/mkdocs/best-of-generator | ||
| - name: update-best-of-list | ||
| run: best-of generate projects.yaml --github-key=${{ secrets.GITHUB_TOKEN }} --libraries-key=${{ secrets.LIBRARIES_KEY }} | ||
| uses: best-of-lists/best-of-update-action@v0.8.5 | ||
| with: | ||
| libraries_key: ${{ secrets.LIBRARIES_KEY }} | ||
| github_key: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Please revert, we must keep using our own fork.
| # - name: create-release | ||
| # uses: softprops/action-gh-release@v2 | ||
| # env: | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # with: | ||
| # tag_name: ${{ env.VERSION }} | ||
| # name: "Update: ${{ env.VERSION }}" | ||
| # body_path: "latest-changes.md" | ||
| # draft: true | ||
| # prerelease: false | ||
| - name: create-release | ||
| uses: softprops/action-gh-release@v2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag_name: ${{ env.VERSION }} | ||
| release_name: "Update: ${{ env.VERSION }}" | ||
| body_path: "latest-changes.md" | ||
| draft: true | ||
| prerelease: false |
There was a problem hiding this comment.
Please revert, we don't want to make any release.
There was a problem hiding this comment.
What is the reason behind this decision?
There was a problem hiding this comment.
They are not useful (it's just a catalog, not an installable library or app), and very noisy (they appear in the home feed) 🙂
There was a problem hiding this comment.
Then maybe also disable/remove those branches/tags as well 😄 to me it looked like it was a semi-finished product
There was a problem hiding this comment.
It's useful to keep it commented in case someone wants to re-enable them in the future 🤷
2 participants
What kind of change does this PR introduce?
Description:
Checklist:
README.mdfile. Projects are only supposed to be added or updated within theprojects.yamlfile since theREADME.mdfile is automatically generated.