Skip to content

fix typo in count function documentation#9

Open
mkuehn10 wants to merge 2 commits intomkearney:masterfrom
mkuehn10:patch-1
Open

fix typo in count function documentation#9
mkuehn10 wants to merge 2 commits intomkearney:masterfrom
mkuehn10:patch-1

Conversation

@mkuehn10
Copy link

sorry for such a lame pull request!

sorry for such a lame pull request!
@EmilHvitfeldt
Copy link
Collaborator

Hello @mkuehn10! Thanks for finding this typo and sending in a PR. Would you mind building the package documentation such that the fix will propagate to the manual pages? that would be great!

@mkuehn10
Copy link
Author

mkuehn10 commented Oct 17, 2019

Yes I can work on that. I also noticed there was no description of n_lowersp or n_capsp in the count documentation either (or in any other documentation). I then investigated how those were created and I assume the p means percentage. I saw the code as:

o$n_capsp <- (o$n_caps + 1L) / (o$n_chars + 1L) I understand why adding 1 to the denominator would make sense, but why add 1 to the numerator here. If there were 0 capital letters then we would want this to be 0. Is this for doing some type of ratio comparison at a later time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants