Conversation
To be used in cases of input packets where a failure shouldn't be a (debug) panic.
Bad peer keys might not have a correct length.
Previously it would present multiple auth events if the client sent subsequent (in-flight?) requests.
Send an error response, proper handling to be implemented later.
channel number is stored in events now. Rename from ch to num since "ch" is already used for the channel itself in some places.
Zero length data inputs are now just ignored. Previously this triggered a debug assertion.
Previously would hit a bug()
Previously the channel would be presented as ready
Once an app calls channel_done() it should not receive any more events or channel data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been testing a server fuzzer target locally, will push that once tidied up. These are some fixes/improvements found while running it.