Convert … character to ... (3 ASCII characters) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
チ was originally only handled for digraphs, and the monograph case was overlooked.
Half width is a common variant in the extant corpus
Add half-width variations for conversion from katakana
Bug fix: convert チ to 'ci'
A lot of the extant corpus uses half-width katakana and full-width spaces. I added them for conversion to latin.
Add half-width support + full-width space conversion
Naively assumes that there should be a single before opening quotes and after all other punctuation. This will inevitably lead to trailing spaces, but that should be trimmable.
Basic punctuation support
The non-ascii ellipsis often occurs in the existing corpus
Owner
|
It is hard to say if I want this to be the default, because semantically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-ascii ellipsis often occurs in the existing corpus
Sorry for four active pull requests, but each is separable from the others