Migrate to next major version of MLX Swift LM#466
Draft
DePasqualeOrg wants to merge 3 commits intoml-explore:mainfrom
Draft
Migrate to next major version of MLX Swift LM#466DePasqualeOrg wants to merge 3 commits intoml-explore:mainfrom
DePasqualeOrg wants to merge 3 commits intoml-explore:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next major version of MLX Swift LM will decouple from tokenizer and model downloading packages. This PR demonstrates the changes needed to migrate to the new version, based on ml-explore/mlx-swift-lm#118.
Note that many of these changes would be necessary anyway, since Swift Transformers is migrating from its internal Hub client to Swift Hugging Face for downloading.
501ed63 demonstrates the migration for MLX Swift Examples using Swift Tokenizers and Swift HF API, while 0baa51b demonstrates replacing these with Swift Transformers and Swift Hugging Face.