Fix LFM2 tool calling with nested parentheses in arguments#152
Merged
davidkoski merged 10 commits intoml-explore:mainfrom Mar 20, 2026
Merged
Fix LFM2 tool calling with nested parentheses in arguments#152davidkoski merged 10 commits intoml-explore:mainfrom
davidkoski merged 10 commits intoml-explore:mainfrom
Conversation
4 tasks
Contributor
Author
|
@davidkoski any chance this could be merged? |
davidkoski
approved these changes
Mar 20, 2026
Collaborator
davidkoski
left a comment
There was a problem hiding this comment.
Looks good. I wonder if this will be tripped up with batch tokens where it might have parens in trailing text?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PythonicToolCallParserregex that truncated tool call arguments containing nested parentheses (e.g.,requests.get('url')inside acode=argument). The root cause was optional brackets\[?...\]?in the regex -- the Python reference uses required brackets\[...\], which forces the non-greedy.*?to backtrack past inner)characters. A string-based fallback handles the without-brackets case."*.jinja"todownloadModelfile patterns sochat_template.jinjais cached alongside model weights for offline robustness.Context
LFM2-24B-A2B (LiquidAI/LFM2-24B-A2B) uses Pythonic tool call syntax wrapped in
<|tool_call_start|>/<|tool_call_end|>tags. When argument values contain nested parentheses (common with code-execution tools likesandbox_run_script), the regex matched the first)inside the value rather than the correct outer one, producing mangled arguments.Reference:
mlx-lm/tool_parsers/pythonic.pyTest plan
[run_script(code="requests.get('url')")])run_script(code="print('hello')"))ToolTestspass (no regressions)Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes