hold evalLock during mlx_save_safetensors etc#379
Open
davidkoski wants to merge 1 commit intomainfrom
Open
Conversation
- fix #378 - save functions call eval internally and must be run under evalLock
davidkoski
commented
Mar 27, 2026
| _ = try withError { | ||
| mlx_save_safetensors(path.cString(using: .utf8), mlx_arrays, mlx_metadata) | ||
| _ = evalLock.withLock { | ||
| mlx_save_safetensors(path.cString(using: .utf8), mlx_arrays, mlx_metadata) |
Collaborator
Author
There was a problem hiding this comment.
internally these functions prepare contiguous arrays and use eval to realize them. eval is not thread safe so the entire thing has to be run under the evalLock.
See #378 for the use case.
davidkoski
added a commit
to ml-explore/mlx-swift-lm
that referenced
this pull request
Mar 27, 2026
- some concurrency issues snuck in for test support - fix and prevent more from coming in by switching Package to swift 6 - depends on ml-explore/mlx-swift#379
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Verified via concurrent tests in mlx-swift-lm.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes