Skip to content

Thread safe compiler cache #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CC-Yeh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Thread safe compiler cache #2619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlx/compile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright © 2023-2024 Apple Inc.
#include <cstdlib>
#include <map>
#include <mutex>
#include <sstream>
#include <unordered_map>
#include <unordered_set>
Expand Down Expand Up @@ -305,6 +306,7 @@ class CompilerCache {
const std::vector<array>& inputs,
bool shapeless,
const std::vector<uint64_t>& constants) {
std::lock_guard<std::mutex> guard(mtx_);
// Find the cache entries for |fun_id|.
std::vector<CacheEntry>& entries = cache_[fun_id];

Expand Down Expand Up @@ -353,10 +355,12 @@ class CompilerCache {
}

void erase(std::uintptr_t fun_id) {
std::lock_guard<std::mutex> guard(mtx_);
cache_.erase(fun_id);
}

void clear() {
std::lock_guard<std::mutex> guard(mtx_);
cache_.clear();
}

Expand All @@ -368,6 +372,7 @@ class CompilerCache {
}

friend CompilerCache& compiler_cache();
std::mutex mtx_;
std::unordered_map<std::uintptr_t, std::vector<CacheEntry>> cache_;
};

Expand Down