Fix return value in einsum_path for simple contractions#3232
Merged
angeloskath merged 3 commits intoml-explore:mainfrom Mar 10, 2026
Merged
Fix return value in einsum_path for simple contractions#3232angeloskath merged 3 commits intoml-explore:mainfrom
angeloskath merged 3 commits intoml-explore:mainfrom
Conversation
angeloskath
approved these changes
Mar 9, 2026
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
The output produced is garbage and should be fixed.
I think the language is a bit harsh but I do appreciate the fix 🤣
But seriously, thanks for the fix.
Member
|
Ah sorry, linter again. Will merge after. |
Contributor
Author
|
Sorry about that I had set up the pre-commit to run on any pushes upstream but it seems it was not working |
Contributor
Author
|
Sorry I thought that was the technical term? My old CS professor always joked about being a janitor with all the garbage collection... 🤣
… On Mar 9, 2026, at 6:37 PM, Angelos Katharopoulos ***@***.***> wrote:
@angeloskath approved this pull request.
The output produced is garbage and should be fixed.
I think the language is a bit harsh but I do appreciate the fix 🤣
But seriously, thanks for the fix.
—
Reply to this email directly, view it on GitHub <#3232 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B3BZEIZ5F4WPYCPCP6ZGVJT4P5BTFAVCNFSM6AAAAACWMFFFZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMJYGYZTCNRYHA>.
You are receiving this because you authored the thread.
|
Contributor
Author
|
done!
… On Mar 9, 2026, at 6:38 PM, Angelos Katharopoulos ***@***.***> wrote:
angeloskath
left a comment
(ml-explore/mlx#3232)
<#3232 (comment)>
Ah sorry, linter again. Will merge after.
—
Reply to this email directly, view it on GitHub <#3232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B3BZEI2L4YEYSQ5G75TZBTT4P5BVLAVCNFSM6AAAAACWMFFFZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRXGM3TGOJXG4>.
You are receiving this because you authored the thread.
|
zcbenz
changed the title
angeloskath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
#3222
Describe the bug
User-visible API output (einsum_path info string) can be incorrect and nondeterministic for common equations with one or two operands. The output produced is garbage and should be fixed.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes