fix(api): remove logfire from api server#1055
Merged
Conversation
Member
|
Thanks, logfire free plan was also deprecated. However I think we could migrate to pydantic v2 without breaking change, could you test it from this PR ? |
Collaborator
Author
|
Info about the migration to pydantic v2 --> #1056 |
SaboniAmine
approved these changes
Feb 8, 2026
Member
|
OK lets do it in a separate PR! |
Collaborator
Author
|
Just saw your comment after @SaboniAmine sorry!
then I can remove logfire entirely n? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
=======================================
Coverage 68.26% 68.26%
=======================================
Files 41 41
Lines 3847 3847
=======================================
Hits 2626 2626
Misses 1221 1221 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error in the API server that keeps popping up.
The error
What it means
Logfire is using
pydantic v2whereas thecarbonserveris usingpydantic v1. They are not compatible.The solution
Remove
logfirefrom the installed packages (it was not running anyhow). We will reactivate it when we migrate to pydantic v2.