Skip to content

fix(api): remove logfire from api server#1055

Merged
inimaz merged 4 commits intomasterfrom
fix/logfire-carbonserver
Feb 8, 2026
Merged

fix(api): remove logfire from api server#1055
inimaz merged 4 commits intomasterfrom
fix/logfire-carbonserver

Conversation

@inimaz
Copy link
Collaborator

@inimaz inimaz commented Feb 8, 2026

There is an error in the API server that keeps popping up.

The error

2026-02-08T14:54:01.571Z
Caught an internal error in Logfire. Your code should still be running fine, just with less telemetry. This is just logging the internal error.

...

AttributeError: module 'pydantic' has no attribute 'RootModel'

What it means

Logfire is using pydantic v2 whereas the carbonserver is using pydantic v1. They are not compatible.

The solution

Remove logfire from the installed packages (it was not running anyhow). We will reactivate it when we migrate to pydantic v2.

@inimaz inimaz requested a review from a team as a code owner February 8, 2026 15:35
@SaboniAmine
Copy link
Member

Thanks, logfire free plan was also deprecated. However I think we could migrate to pydantic v2 without breaking change, could you test it from this PR ?

@inimaz
Copy link
Collaborator Author

inimaz commented Feb 8, 2026

Info about the migration to pydantic v2 --> #1056

@SaboniAmine
Copy link
Member

OK lets do it in a separate PR!

@inimaz
Copy link
Collaborator Author

inimaz commented Feb 8, 2026

Just saw your comment after @SaboniAmine sorry!

logfire free plan was also deprecated

then I can remove logfire entirely n?

@inimaz inimaz requested a review from SaboniAmine February 8, 2026 16:11
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.26%. Comparing base (2d52a20) to head (ff83ae3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1055   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files          41       41           
  Lines        3847     3847           
=======================================
  Hits         2626     2626           
  Misses       1221     1221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inimaz inimaz changed the title fix(api): deactivate logfire if not compatible fix(api): remove logfire from api server Feb 8, 2026
@inimaz inimaz merged commit 53eec49 into master Feb 8, 2026
13 checks passed
@inimaz inimaz deleted the fix/logfire-carbonserver branch February 8, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants