Fix recursively_populate_jsonld failing when given array values with non-dict elements#708
Open
brendon-boldt wants to merge 2 commits intomlcommons:mainfrom
Open
Fix recursively_populate_jsonld failing when given array values with non-dict elements#708brendon-boldt wants to merge 2 commits intomlcommons:mainfrom
brendon-boldt wants to merge 2 commits intomlcommons:mainfrom
Conversation
Test if recursively_populate_json can handle values that are arrays with multiple, non-dict elements (e.g., ["a", "b"]).
Change recursively_populate_jsonld such that when it receives non-dicts, it returns them immediately instead of blindly treating them like dicts.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698. Adds simple test with multiple, non-dict values in JSON-LD (e.g.,
{"a": ["b", "c"]}) which fails with the current implementation ofrecursively_populate_jsonld. Fixes the function so that it passes the test.