Preserve np.ndarray in field value casting#868
Open
tombagby wants to merge 5 commits intomlcommons:mainfrom
Open
Preserve np.ndarray in field value casting#868tombagby wants to merge 5 commits intomlcommons:mainfrom
tombagby wants to merge 5 commits intomlcommons:mainfrom
Conversation
The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional? If resampling is desired, the field description should include an explicit target sample rate to enable.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
reviewed
May 9, 2025
| [np.array([1, 2, 3]), DataType.FLOAT32, np.array([1.0, 2.0, 3.0])], | ||
| ], | ||
| ) | ||
| def test_cast_value_ndarray(): |
Contributor
There was a problem hiding this comment.
def test_cast_value_ndarray(conforms_to, value, data_type, expected):
...
marcenacp
reviewed
May 9, 2025
Contributor
marcenacp
left a comment
marcenacp
left a comment
There was a problem hiding this comment.
Thanks!
LGTM if you fix the red tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current _cast_value will always cast an np.ndarray to a python list. Instead, when the value is an array and the type to cast to is a numpy dtype, use astype and preserve the array.