Catch up the v1.1 dataset files to match the latest context in rdf.py#953
Open
SujataSaurabh wants to merge 1 commit intomlcommons:mainfrom
Open
Catch up the v1.1 dataset files to match the latest context in rdf.py#953SujataSaurabh wants to merge 1 commit intomlcommons:mainfrom
SujataSaurabh wants to merge 1 commit intomlcommons:mainfrom
Conversation
This change should not update anything else except context, and may reorder a few things.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benjelloun
approved these changes
Oct 6, 2025
| "arrayShape": "-1,-1,-1", | ||
| "dataType": "sc:Float", | ||
| "isArray": true, | ||
| "arrayShape": "-1,-1,-1", |
Contributor
There was a problem hiding this comment.
Nit: It makes more sense to keep the arrayShape property right after isArray.
| "@id": "default/observation.state", | ||
| "name": "default/observation.state", | ||
| "description": "Column 'observation.state' from the Hugging Face parquet file.", | ||
| "arrayShape": "19", |
Contributor
There was a problem hiding this comment.
Nit: I think the most meaningful order is dataType, isArray, arrayShape.
| "@id": "default/action", | ||
| "name": "default/action", | ||
| "description": "Column 'action' from the Hugging Face parquet file.", | ||
| "arrayShape": "19", |
| "@id": "default/steps", | ||
| "name": "default/steps", | ||
| "description": "Column 'steps' from the Hugging Face parquet file.", | ||
| "arrayShape": "-1,-1", |
Contributor
|
Hi @SujataSaurabh , thank you for your contribution! In any case, I think it would make sense to wait to update the 1.1 datasets until we are sure that nothing else is going to change in the 1.1 specs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change should not update anything else except context, and may reorder a few things. This is a first step towards #876