allign port number for vLLM Docker run command with example config file#109
allign port number for vLLM Docker run command with example config file#109anandhu-eng wants to merge 3 commits intomainfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @anandhu-eng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a documentation update. It corrects an inconsistency in the example Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the port number in the vLLM Docker run command to align with the example configuration file, which is a good correction. However, the documentation update is incomplete. The 'Debugging' section still contains references to the old port number, which could cause confusion. I've added a comment suggesting updates to that section for consistency.
|
|
||
| ``` | ||
| docker run --runtime nvidia --gpus all -v ${HF_HOME}:/root/.cache/huggingface --env "HUGGING_FACE_HUB_TOKEN=$HF_TOKEN" -p 8000:8000 --ipc=host vllm/vllm-openai:latest --model ${MODEL_NAME} --gpu_memory_utilization 0.95 | ||
| docker run --runtime nvidia --gpus all -v ${HF_HOME}:/root/.cache/huggingface --env "HUGGING_FACE_HUB_TOKEN=$HF_TOKEN" -p 3000:3000 --ipc=host vllm/vllm-openai:latest --model ${MODEL_NAME} --gpu_memory_utilization 0.95 |
There was a problem hiding this comment.
This change correctly aligns the vLLM port with the configuration file. However, the 'Debugging' section in this file is now outdated as it still refers to port 8000.
To maintain consistency, please update the mitmproxy command and the related explanation in the 'Debugging' section to use port 3000.
For example, line 70 should be:
mitmproxy -p 8001 --mode reverse:http://localhost:3000/The surrounding text should also be updated to refer to port 3000.
Additionally, there's a typo on line 73: mitmproxy is launched on port 8001, not 8081.
2 participants
What does this PR do?
Type of change
Related issues
Testing
Checklist