#114 doc: Fixup markdown documentation#180
Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity and accuracy of the project's documentation. It addresses outdated information regarding command-line interface parameters, streamlines the development environment setup, and refines the description of the project's internal structure and dependency management practices. The changes aim to provide a more consistent and up-to-date guide for both users and developers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several documentation files to align with recent changes in the project's tooling and API. Key changes include updating dependency management instructions to use pyproject.toml, replacing black/isort/flake8 with ruff, and reflecting API changes like renaming --report-path to --report-dir. The documentation changes are mostly accurate and consistent. However, I've identified a couple of areas in the examples within docs/LOCAL_TESTING.md where removing result-checking commands has made the examples less complete. My suggestions aim to restore this helpful information for users.
There was a problem hiding this comment.
Pull request overview
Updates repository documentation to reflect recent CLI and developer workflow changes (notably shifting benchmark reporting to --report-dir, moving dependency management to pyproject.toml extras, and standardizing on Ruff).
Changes:
- Replace
--report-path(and--outputin examples) with--report-diracross local testing and CLI quick reference docs. - Update development setup instructions to use
pip install -e ".[dev,test]"and Ruff for formatting/linting. - Refresh AGENTS.md CLI-mode notes and the source tree map to match current module layout.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/LOCAL_TESTING.md | Updates benchmark examples to use --report-dir and revises “View Results” guidance. |
| docs/DEVELOPMENT.md | Aligns dev setup, formatting, linting, pytest-asyncio guidance, and dependency instructions with current tooling. |
| docs/CLI_QUICK_REFERENCE.md | Updates benchmark examples and YAML-mode notes to match current CLI flags/constraints. |
| AGENTS.md | Updates CLI mode constraints and source tree listing to reflect current code organization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Review Council — Multi-AI Code Review CouncilReviewed by: Claude Found 0 issues across 6 files. Verification SummaryThe Claude reviewer verified each documentation change against the actual codebase:
All changes are factually accurate and align with the current state of the codebase. 🤖 Generated with Claude Code |
What does this PR do?
Fixes documentation.
Closes #114
Type of change
Related issues
Testing
Checklist