feat: Enable unit tests for dataset presets#194
Conversation
- Add test_dataset_presets.py with 20 test cases for 6 presets across 5 datasets - Add comprehensive testing guide and schema reference documentation Tests verify that transforms work correctly without end-to-end runs, enabling fast regression detection when transform code changes. Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a dedicated unit testing framework for dataset presets. Its primary goal is to ensure the reliability and correctness of data transformations applied by these presets, without the overhead of full end-to-end benchmark runs. This enhancement will significantly improve the development workflow by providing immediate feedback on preset changes and reducing the risk of introducing regressions in data preparation logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great addition, enabling unit tests for dataset presets and providing clear documentation. The tests cover several presets and verify key aspects like instantiation and transform application. My review includes a few suggestions to improve the test suite's efficiency by reducing redundant computations, ensure consistency in marking slow tests, and enhance test coverage for one of the presets. Overall, this is a valuable contribution to the project's test infrastructure.
Signed-off-by: attafosu <thomas.atta-fosu@intel.com>
89ea457
into
feat/attafosu/sglang-openai-api-compatibility
What does this PR do?
Adds unit tests for dataset presets
Type of change
Related issues
Testing
Checklist