Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-submission-checker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ jobs:
git clone https://github.com/mlcommons/mlperf_inference_unofficial_submissions_v5.0 --depth 1
- name: Test MLPerf inference submission checker
run: |
mlcr run,mlperf,inference,submission,checker --adr.inference-src.tags=_branch.$PR_HEAD_REF,_repo.${{ github.event.pull_request.head.repo.html_url }} --adr.inference-src.version=custom --input=`pwd`/mlperf_inference_unofficial_submissions_v5.0 --src_version=v5.0 --extra_args=" --skip-extra-files-in-root-check --skip-extra-accuracy-files-check --skip-all-systems-have-results-check" --quiet
mlcr run,mlperf,inference,submission,checker --adr.inference-src.tags=_branch.$PR_HEAD_REF,_repo.${{ github.event.pull_request.head.repo.html_url }} --adr.inference-src.version=custom --input=`pwd`/mlperf_inference_unofficial_submissions_v5.0 --src_version=v5.0 --extra_args=" --skip-extra-files-in-root-check --skip-extra-accuracy-files-check --skip-all-systems-have-results-check --skip-calibration-check" --quiet
24 changes: 23 additions & 1 deletion tools/submission/submission_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,7 @@ def __init__(
ignore_uncommited=False,
skip_power_check=False,
skip_all_systems_with_results=False,
skip_calibration_check=False
):
self.base = MODEL_CONFIG.get(version)
self.extra_model_benchmark_map = extra_model_benchmark_map
Expand All @@ -896,6 +897,7 @@ def __init__(
self.ignore_uncommited = ignore_uncommited
self.skip_power_check = skip_power_check
self.skip_all_systems_with_results = skip_all_systems_with_results
self.skip_calibration_check = skip_calibration_check

def set_type(self, submission_type):
if submission_type == "datacenter":
Expand Down Expand Up @@ -1092,6 +1094,11 @@ def get_args():
action="store_true",
help="skips the check that all the systems in the systems and measurements folder should have results",
)
parser.add_argument(
"--skip-calibration-check",
action="store_true",
help="skips the check that the calibration documentation should exist",
)
parser.add_argument(
"--scenarios-to-skip",
help="Delimited list input of scenarios to skip. i.e. if you only have Offline results, pass in 'Server'",
Expand Down Expand Up @@ -2229,6 +2236,20 @@ def log_result(
)
results[os.path.join(results_path)] = None

# Check for calibration documentation
if not config.skip_calibration_check and division not in ["open"]:
calibration_path_root = os.path.join(division, submitter, "calibration.md")
calibration_path_doc = os.path.join(division, submitter, "documentation", "calibration.md")
if not (os.path.exists(calibration_path_root)) and (not os.path.exists(calibration_path_doc)):
log.error(
"%s/%s: has not calibration file. One of %s or %s is required",
division,
submitter,
calibration_path_root,
calibration_path_doc
)
results[os.path.join(results_path)] = None

for system_desc in list_dir(results_path):
# we are looking at
# ./$division/$submitter/results/$system_desc, ie
Expand Down Expand Up @@ -3173,7 +3194,8 @@ def main():
args.extra_model_benchmark_map,
ignore_uncommited=args.submission_exceptions,
skip_power_check=args.skip_power_check,
skip_all_systems_with_results = args.skip_all_systems_have_results_check
skip_all_systems_with_results = args.skip_all_systems_have_results_check,
skip_calibration_check = args.skip_calibration_check
)

if args.scenarios_to_skip:
Expand Down
Loading