Merged
Conversation
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
| benchmark_uid: int = typer.Option( | ||
| ..., "--benchmark", "-b", help="UID of the desired benchmark" | ||
| ), | ||
| dataset_auto_approve_mode: str = typer.Option( |
Contributor
There was a problem hiding this comment.
Typer supports Enums to both show the options on a standard format in their CLI help and also do validation on their side (including being case insensitive). See https://typer.tiangolo.com/tutorial/parameter-types/enum/ . I think this would be an improvement.
Contributor
Author
There was a problem hiding this comment.
Thanks Bruno! That's indeed helpful
Contributor
Author
There was a problem hiding this comment.
Thanks Bruno! That's indeed helpful
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
mhmdk0
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
mhmdk0
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
temporarily deployed
to
testing-external-code
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the feature of configuring the benchmark to auto-approve model/dataset associations either always or according to specified email addresses of the owners of the models/datasets.