Updated test_mlc_access.py and added logging and assert statement#123
Merged
arjunsuresh merged 11 commits intomlcommons:devfrom Apr 1, 2025
Merged
Updated test_mlc_access.py and added logging and assert statement#123arjunsuresh merged 11 commits intomlcommons:devfrom
arjunsuresh merged 11 commits intomlcommons:devfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
anandhu-eng
reviewed
Mar 3, 2025
anandhu-eng
reviewed
Mar 6, 2025
anandhu-eng
reviewed
Mar 6, 2025
Contributor
|
Hi @sahilavaran , the error in this test case arose because it tried to access the I think we could provide an endpoint for the users(could be found in this PR) to get the MLC logger. |
Contributor
Author
|
@anandhu-eng added as per your PR |
Contributor
|
Hi @sahilavaran , Thanks for the PR. I have reverted the usage of logger from MLCFlow as it is not needed to be exposed. I have closed the PR that exposed the logger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.