Code changes for supporting llama3_1-405b reference implementation#111
Merged
arjunsuresh merged 9 commits intomlcommons:devfrom Jan 5, 2025
Merged
Code changes for supporting llama3_1-405b reference implementation#111arjunsuresh merged 9 commits intomlcommons:devfrom
arjunsuresh merged 9 commits intomlcommons:devfrom
Conversation
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Jan 4, 2025
| - llama3-402b | ||
| skip_if_env: | ||
| CM_ML_MODEL_LLAMA3_CHECKPOINT_PATH: | ||
| - 'on' |
Collaborator
There was a problem hiding this comment.
Also only if we are in the docker build stage. Otherwise when the path is given we should register it in CM cache
arjunsuresh
reviewed
Jan 4, 2025
| - llama3-402b | ||
| skip_if_env: | ||
| CM_DATASET_LLAMA3_PATH: | ||
| - "on" |
Collaborator
There was a problem hiding this comment.
Same here as for the model.
arjunsuresh
reviewed
Jan 4, 2025
script/get-ml-model-llama3/_cm.yaml
Outdated
| env: | ||
| CM_MODEL_ZOO_ENV_KEY: LLAMA3 | ||
| group: huggingface-stub | ||
| docker: |
Collaborator
There was a problem hiding this comment.
Is this docker section needed?
arjunsuresh
reviewed
Jan 5, 2025
| skip_if_env: | ||
| CM_DATASET_LLAMA3_PATH: | ||
| - "on" | ||
| CM_USE_DATASET_FROM_HOST: |
Collaborator
There was a problem hiding this comment.
This variable is not needed right? Because if the path is directly passed from the host to a container then, this won't work. Same for model.
Contributor
Author
There was a problem hiding this comment.
That's right, thanks. Also I formatted the app-mlperf-inference-mlcommons-python _cm.yaml file with the help of prettier extension in VS Code.
arjunsuresh
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
rclonedirectory path toget-dataset-mlperf-inference-llama3.