Skip to content

Conversation

@anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Nov 25, 2025

Extracts native libraries from the APK to the file system by setting useLegacyPackaging true

https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/dsl/JniLibsPackagingOptions#uselegacypackaging

https://developer.android.com/build/releases/past-releases/agp-4-2-0-release-notes#compress-native-libs-dsl

We previously had this option enabled with android.bundle.enableUncompressedNativeLibs=false, but I accidentally removed it during the AGP version upgrade in PR #1029.

> Failed to apply plugin 'com.android.internal.application'.
   > The option 'android.bundle.enableUncompressedNativeLibs' is deprecated.
     The current default is 'true'.
     It was removed in version 8.1 of the Android Gradle plugin.

@anhappdev anhappdev requested a review from a team as a code owner November 25, 2025 11:14
@anhappdev anhappdev marked this pull request as draft November 25, 2025 11:14
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sonarqubecloud
Copy link

@anhappdev
Copy link
Collaborator Author

@freedomtan @Mostelk Please test the Play Store app "593 (5.0.3)" at this link:
https://play.google.com/apps/internaltest/4700449654979131232

@freedomtan
Copy link
Contributor

@freedomtan @Mostelk Please test the Play Store app "593 (5.0.3)" at this link: https://play.google.com/apps/internaltest/4700449654979131232

YES, it works as expected. @Mostelk please check it your devices

@anhappdev anhappdev marked this pull request as ready for review December 2, 2025 04:53
@freedomtan
Copy link
Contributor

Let's merge it. @Mostelk to test on FLIP7

@anhappdev anhappdev merged commit 5b33b74 into master Dec 2, 2025
40 of 41 checks passed
@anhappdev anhappdev deleted the anh/fix-permission-issue-with-playstore-app branch December 2, 2025 06:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@Mostelk
Copy link

Mostelk commented Dec 3, 2025

Let's merge it. @Mostelk to test on FLIP7

Works well on Flip7!

@Mostelk
Copy link

Mostelk commented Dec 3, 2025

@anhappdev please work on make it published on PlayStore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants