Add tags for preceding mlflow run ids and modelgauge run ids #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere it crashes the page in these cases.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
approved these changes
Jul 8, 2025
rogthefrog
left a comment
rogthefrog
left a comment
There was a problem hiding this comment.
Just one question. I don't know the code base enough to assess its importance.
superdosh
commented
Jul 8, 2025
| for annotator in annotators: | ||
| score = score_annotator(annotator, annotations_df, ground_truth_df) | ||
| for metric in score: | ||
| mlflow.log_metric(f"{annotator}_{metric}", score[metric]) |
Contributor
Author
There was a problem hiding this comment.
I forgot to add a comment in the code, so adding here for posterity: the reason we need this now (and not before) is due to a bug introduced in mlflow 3 (from a newer version of graphql). We can track it here: mlflow/mlflow#16555
Basically if we try to log a nan or inf, it works on the mlflow side with no errors, but the gui crashes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24