-
Notifications
You must be signed in to change notification settings - Fork 0
Standardized modelgauge column names #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
| except Exception as e: | ||
| print(f"Failed to log stats for {annotator_uid}: {e}") | ||
| with AnnotationDataset(data_path, "r") as dataset: | ||
| for item in dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sure how this works when there are multiple annotators? If I'm reading the __iter__ in modelgauge.dataset correctly, each row produces one item, but I think if there are multiple annotators, each row will contain multiple annotator_uids? Or did that change too in the modelgauge PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That changed in the modelgauge PR! Every row is one response and one annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably why the randomness changed! Since before it was looping row, and then a for loop around the annotators per row, but the order of the annotators may not match the order modelgauge is now producing.
I'm good on this then!
No description provided.