Draft
Conversation
ShadowJonathan
commented
Jun 14, 2023
mormaer
requested changes
Jun 14, 2023
| // lemmy_db_schema::source::language::Language | ||
| struct APILanguage: Decodable { | ||
| let id: Int | ||
| let code: String |
Collaborator
There was a problem hiding this comment.
I wonder if these codes will match what Apple give us back from the Natural Language framework, which appears to be BCP 47?
| let federationEnabled: Bool | ||
| let federationDebug: Bool | ||
| let federationWorkerCount: Int | ||
| let captchaEnabled: Bool |
Collaborator
There was a problem hiding this comment.
do you know where captcha is used, is it during registration? does it impact the application in any way for the operations we currently perform with the API?
Collaborator
Author
There was a problem hiding this comment.
I haven't implemented registration yet, there's captchas for endpoints, yeah
Merged
ShadowJonathan
force-pushed
the
add-api-types
branch
from
bb593f5 to
88d1844
Compare
Closed
Collaborator
Author
|
I'm converting this to draft, so that I can implement the rest of the API types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a lot of types from mlemgroup/mlem#52, the only missing ones are a lot of the PM, User, Admin, and the Misc endpoints