Merged
Conversation
I want to use the name "compressor" for a different object. -ion makes more sense a stage suffix than -or.
always initialize Log with Warnings; don't lazy-load it
info about file paths to compressor object. Replaces local variables in Compression with queries to the compressor object.
creates TiffToPnm module for doing the compression
It only takes the first page. Also puts tifftopnm call in a TiffTools module because compress is a more complicated action and tiffcp is only used here.
remove minitest for tiff date because it's covered in the compressor test
new.jp2 -> output.jp2 | new_path -> output_path filename.tif-page1 -> output.tif | page1_path -> output_path
this makes it match what's going on for jp2 and paves the way for being able to use the build in temp dir for the real deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.