refactor: graduate DefaultOptionKeys out of experimental namespace#238
Merged
TomKaltofen merged 3 commits intomainfrom Mar 27, 2026
Merged
refactor: graduate DefaultOptionKeys out of experimental namespace#238TomKaltofen merged 3 commits intomainfrom
TomKaltofen merged 3 commits intomainfrom
Conversation
TomKaltofen
reviewed
Mar 24, 2026
TomKaltofen
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultOptionKeysfrommloda_plugins.feature_group.experimental.default_options_keytomloda_plugins.feature_group.default_options_keyas a stable import pathDeprecationWarningpointing to the new locationCloses #233
Test plan
test_default_options_key.pytests pass via the shimtoxrun: 2196 passed, 124 skipped (13 pre-existing failures unrelated to this change)ruff checkclean on all changed filesmypy --strictclean on all changed files