chore: enable ruff UP006/UP007, replace legacy typing imports#239
Closed
chore: enable ruff UP006/UP007, replace legacy typing imports#239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlto enforce modern type annotation syntaxList[X]withlist[X],Dict[K,V]withdict[K,V],Optional[X]withX | None,Union[X,Y]withX | Yruff check .to tox commands so lint rules are enforced alongside format, mypy, and bandit# type: ignorecomments in node_centrality and forecasting modulesCloses #234
Test plan
ruff check .passes with zero violationsmypy --strictpasses (572 source files, 0 errors)toxpytest run: 2191 passed, 124 skipped (13 pre-existing failures unrelated to this change)ruff formatclean (3 files reformatted by auto-fix)