Skip to content

Feat/serialization support#173

Closed
Havunen wants to merge 6 commits intomlondschien:mainfrom
Havunen:feat/serialization_support
Closed

Feat/serialization support#173
Havunen wants to merge 6 commits intomlondschien:mainfrom
Havunen:feat/serialization_support

Conversation

@Havunen
Copy link
Contributor

@Havunen Havunen commented Feb 20, 2026

This PR adds support for serialization & deserialization of fitted tree.

This PR builds on: #172

Fixes #104

@Havunen Havunen force-pushed the feat/serialization_support branch from c83f9e3 to 6f60d14 Compare February 20, 2026 07:49
@mlondschien
Copy link
Owner

This should be possible without +600 lines.

@Havunen
Copy link
Contributor Author

Havunen commented Feb 21, 2026

@mlondschien It's +600 because its based on the other PR I opened.

https://github.com/Havunen/biosphere/blob/6f60d145a0ec0b1d7bba13f0c6e7f4201c3e5d36/benches/bench_tree_serde.rs

was created to test fitting vs deserialization.

These attributes are the thing:

#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]

@mlondschien
Copy link
Owner

Then please create a PR from main with only the necessary changes:

  • implementation of serialization
  • tests of the new feature
  • changelog entry

@Havunen
Copy link
Contributor Author

Havunen commented Feb 21, 2026

ok done: #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to save the model after training it?

2 participants