Open
Conversation
ianlini
reviewed
Mar 28, 2019
twstock/analytics.py
Outdated
| data = [x for x in data if x is not None] | ||
|
|
||
| result = [] | ||
| data = data[:] |
Contributor
There was a problem hiding this comment.
這行可以移到上面那個 if 之後的 else,避免多複製一次 data
Author
|
@mlouielu hi, 我發現這個沒過的部分是太頻繁的對原始資料網站做 request,導致無法連上,已經不是跟這個議題的程式有關。請問該怎麼解決才能完成這個MR呢? |
|
請問這個連線有限制嗎 我要抓全部股票31天內的資訊 抓到中間某之就錯誤 還是其他問題 ConnectionError: ('Connection aborted.', ConnectionResetError(10054, '遠端主機已強制關閉一個現存的連線。', None, 10054, None)) |
Author
|
@hourtest 這個好像 request 太頻繁會被 ban ip |
Owner
|
You can use RoundRobinProxy to prevent this issue.
hourtest <notifications@github.com> 於 2019年11月27日 週三 09:25 寫道:
… 請問這個連線有限制嗎 我要抓全部股票31天內的資訊
抓到中間某之就錯誤 還是其他問題
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63?email_source=notifications&email_token=AG3QA2EOGGQDC4PEAH7PRV3QVXD23A5CNFSM4HB4VKSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFH64EQ#issuecomment-558886418>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG3QA2F5LCCZME5FM3IAEVTQVXD23ANCNFSM4HB4VKSA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
我嘗試解這個問題, 不確定是不是這樣做