perf: use more lengths() and data.table::setattr() (#1412)

m-muecke · web-flow · commit 3c6d7dc6d41d · 2025-11-23T18:22:49.000+01:00
diff --git a/R/PredictionData.R b/R/PredictionData.R
@@ -28,7 +28,7 @@ new_prediction_data = function(li, task_type) {
   class(li) = c(fget_key(mlr_reflections$task_types, task_type, "prediction_data", "type"), "PredictionData")
 
   for (i in seq_along(extra_attributes)) {
-    attr(li, names(extra_attributes)[i]) = extra_attributes[[i]]
+    setattr(li, names(extra_attributes)[i], extra_attributes[[i]])
   }
 
   li
diff --git a/R/PredictionDataClassif.R b/R/PredictionDataClassif.R
@@ -58,7 +58,7 @@ check_prediction_data.PredictionDataClassif = function(pdata, train_task, ...) {
 
   if (!is.null(pdata$extra)) {
     assert_list(pdata$extra, names = "unique")
-    len = map_int(pdata$extra, length)
+    len = lengths(pdata$extra)
     if (any(len != n)) {
       error_learner_predict("Extra data must have the same length as the number of predictions")
     }
diff --git a/R/PredictionDataRegr.R b/R/PredictionDataRegr.R
@@ -53,7 +53,7 @@ check_prediction_data.PredictionDataRegr = function(pdata, ...) { # nolint
 
   if (!is.null(pdata$extra)) {
     assert_list(pdata$extra, names = "unique")
-    len = map_int(pdata$extra, length)
+    len = lengths(pdata$extra)
     if (any(len != n)) {
       error_learner_predict("Extra data must have the same length as the number of predictions")
     }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ new_prediction_data = function(li, task_type) {`
`28`	`28`	`class(li) = c(fget_key(mlr_reflections$task_types, task_type, "prediction_data", "type"), "PredictionData")`
`29`	`29`
`30`	`30`	`for (i in seq_along(extra_attributes)) {`
`31`		`- attr(li, names(extra_attributes)[i]) = extra_attributes[[i]]`
	`31`	`+ setattr(li, names(extra_attributes)[i], extra_attributes[[i]])`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`li`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ check_prediction_data.PredictionDataClassif = function(pdata, train_task, ...) {`
`58`	`58`
`59`	`59`	`if (!is.null(pdata$extra)) {`
`60`	`60`	`assert_list(pdata$extra, names = "unique")`
`61`		`- len = map_int(pdata$extra, length)`
	`61`	`+ len = lengths(pdata$extra)`
`62`	`62`	`if (any(len != n)) {`
`63`	`63`	`error_learner_predict("Extra data must have the same length as the number of predictions")`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ check_prediction_data.PredictionDataRegr = function(pdata, ...) { # nolint`
`53`	`53`
`54`	`54`	`if (!is.null(pdata$extra)) {`
`55`	`55`	`assert_list(pdata$extra, names = "unique")`
`56`		`- len = map_int(pdata$extra, length)`
	`56`	`+ len = lengths(pdata$extra)`
`57`	`57`	`if (any(len != n)) {`
`58`	`58`	`error_learner_predict("Extra data must have the same length as the number of predictions")`
`59`	`59`	`}`