encapsulate train and predict of PipeOps #541
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encapsulate
trainandpredictofPipeOps.Adding active bindings:
timingslogwarningserrorsencapsulateand private
.encapsulatelikeLearners have (by default, aLearner'sencapsulateis propagated to thePipeOp(if relevant) e.g. in case ofPipeOpLearnerCV,PipeOpLearnerandas_pipeop.Learner, ...).A
Graphis not encapsulated but naturally it'sPipeOps are.GraphLearners are (already) naturally encapsulated because they areLearners. Additionally they gain thetimings_pipeopsactive binding (closes #536).Illustration of a
GraphLearnertiming_pipeops:Could also add an entry for the time of the glue code e.g., here
0.21 - 0.036 - 0.030 = 0.144#FIXME: need the following from
mlr3exported:mlr3:::assert_ro_bindingmlr3:::get_privatemlr3:::append_logmlr3:::get_log_condition