Open
Conversation
Pull test-fix into interface branch
|
Very cool! This looks incredibly useful. Let us know if we can help in any way |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 90.74% 90.48% -0.26%
==========================================
Files 23 24 +1
Lines 2475 2639 +164
==========================================
+ Hits 2246 2388 +142
- Misses 229 251 +22
☔ View full report in Codecov by Sentry. |
Merge HEAD into `gstatsim-interface`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GatorGlaciology, this might be interesting for you.
This pull request introduces an preliminary interface to GStatSim. There are 3 main options for interfacing:
prediction_gridfrom aVariograminstanceskrige_sgsorokrige_sgssimulation from aVariogramskrige_sgsorokrige_sgsin parallel, from aVariograminstanceadditionally, the interface defines a
Gridclass, which generates theprediction_gridbut keeps track of the shape needed for the target field, to transform the result. @GatorGlaciology, maybe this class is also helpful for you? I could open a pull request to add it to GStatSim instead of SciKit-GStat, if you are interested.interfaces
prediction grid
You can generate a
prediction_gridlike:simulation parameters
The simulation params can be accessed via the interface
all in one
And finally use the simulation directly
This creates a list of 8 simulated fields. If 8 cores are available, this is as fast as using GStatSim only (or n_jobs=1) as each simulation is run in parallel.
ToDos
@GatorGlaciology, I will add a bit of docs and tests. Meanwhile you are more than welcome to comment on this interface.
I also need to define, which Variogram instances actually can be exported to GStatSim.