Improve Spawning Processes, using errors.As #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
reviewed
Sep 29, 2025
Collaborator
eliben
left a comment
eliben
left a comment
There was a problem hiding this comment.
Thanks! Overall I agree with the change - just a couple of small comments
| // command (e.g. wrong path), and `*exec.ExitError` | ||
| // if the command ran but exited with a non-zero return | ||
| // code. | ||
| // command (e.g. executable file not found in $PATH), |
Collaborator
There was a problem hiding this comment.
Please keep the original comment here
| if err != nil { | ||
| switch e := err.(type) { | ||
| case *exec.Error: | ||
| var ( |
Collaborator
There was a problem hiding this comment.
I'd just do:
var execErr *exec.Error
var exitErr *exec.ExitError
IMHO saving one var keyword doesn't justify the two extra lines
Contributor
Author
|
Sure thing, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go 1.13, the new function errors.As was added, which examines the error tree looking for an error that can be assigned to the target. Using As is preferable to the approach shown in Go by Example, because As will succeed even if the error is wrapped.
Note: In this example the error is not wrapped, but since Go by Example is a learning resource, the recommended way of examining errors should be demonstrated.