Skip to content

Expand end2end in examples to be able to compare shortcut and naive#260

Open
vivaansinghvi07 wants to merge 31 commits intomasterfrom
end2end-naive-reconstruction
Open

Expand end2end in examples to be able to compare shortcut and naive#260
vivaansinghvi07 wants to merge 31 commits intomasterfrom
end2end-naive-reconstruction

Conversation

@vivaansinghvi07
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.55%. Comparing base (67267aa) to head (6016a13).

Files with missing lines Patch % Lines
hstrat/dataframe/_surface_unpack_reconstruct.py 64.70% 6 Missing ⚠️
hstrat/dataframe/surface_unpack_reconstruct.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   95.60%   95.55%   -0.06%     
==========================================
  Files         738      738              
  Lines       11495    11510      +15     
==========================================
+ Hits        10990    10998       +8     
- Misses        505      512       +7     
Flag Coverage Δ
tests 95.55% <57.14%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmore500
Copy link
Owner

mmore500 commented Oct 10, 2025

@vivaansinghvi07

Thanks for opening this up! Apologies for the delay in following up here…

Could you take a look at these two items to start out with, and then DM me to make a second pass for a more comprehensive review?

  • Repository has been dormant for a while, so CI has been disabled. Turned it back on (run for your branch is here), but it’s been so long I’m guessing it will need some general maintenance to pass… if nontrivial it might make sense to fix CI in a separate PR.
  • Could you take a look at these two items four Codacy issues? Looks like they are related to bash quoting and to tmpdir usage (recent experiences have convinced me we should at least avoid hardcoded /tmp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants