Remove unused methods and types related to memory mapping#1383
Merged
wks merged 3 commits intommtk:masterfrom Sep 2, 2025
Merged
Remove unused methods and types related to memory mapping#1383wks merged 3 commits intommtk:masterfrom
wks merged 3 commits intommtk:masterfrom
Conversation
We remove the `protect` method and the `Mmapper::Protected` state. This is because Mmapper cannot protect the memory at the granularity desired by its users. Spaces that wish to protect pages of memory should directly call `mprotect` while the space still owns the memory. We also remove the unused `eagerly_mmap_all_spaces` method. Fixes: mmtk#1348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove the
protectmethod and theMmapper::Protectedstate. This is because Mmapper cannot protect the memory at the granularity desired by its users. Spaces that wish to protect pages of memory should directly callmprotectwhile the space still owns the memory.We also remove the unused
eagerly_mmap_all_spacesmethod. It has never been implemented or used since it was added to JikesRVM MMTk.We also remove
Space::ensure_mapped. It was used for the boot image back in JikesRVM. We now use theVMSpacefor boot images, and it can callMMAPPER.mark_as_mappedto mark the memory as mapped in theMmapperwithout actually callingmmap, assuming the VM has already mapped the memory. So we remove the redundantSpace::ensure_mappedmethod.Fixes: #1348