test: improve type builder unit tests #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce narrow interface to allow for a fake input to be used in tests easily - write tests to cover type building starting from IRModel representation rather than going the whole way through form openapi spec on disk to result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISchemaProviderinterface to make unit testingTypeBuildereasierTypeBuildertest suite into unit tests that use theIRModelrepresentations directly, and integration tests that go the whole way from disk through to theTypeBuilderts.SourceFilerepresentations and enablingskipLibCheck(between both takes it from ~20s -> <1s)